Fix strptime in python_script #133159
Merged
Fix strptime in python_script #133159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: python_script
small-pr
emontnemery
reviewed
Dec 17, 2024
| async def test_import_allow_strptime( | ||
| hass: HomeAssistant, caplog: pytest.LogCaptureFixture | ||
| ) -> None: | ||
| """Test that prohibited augmented assignment operations raise an error.""" |
| async def test_no_other_imports_allowed( | ||
| hass: HomeAssistant, caplog: pytest.LogCaptureFixture | ||
| ) -> None: | ||
| """Test that prohibited augmented assignment operations raise an error.""" |
|
~~ @gjohansson-ST Looking at the linked issue, #132469, it seems this is a workaround for some change in Python 3.13. Can you please elaborate what the change in CPython is, and what the workaround does? ~~ Nevermind, I checked the change myself and updated the PR description |
emontnemery
reviewed
Dec 17, 2024
frenck
approved these changes
Dec 17, 2024
frenck
pushed a commit
that referenced
this pull request
Dec 17, 2024
Co-authored-by: Erik Montnemery <erik@montnemery.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
In Python 3.13,
datetime.datetime.strptimedoes a local import of_strptime.This breaks
python_scriptscripts which calldatetime.datetime.strptimebecause we don't allow imports.As a workaround, we add an allow-list of safe import,
_strptimeis currently the only allowed import.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: