Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nice-go to 1.0.0 #133185

Merged
merged 3 commits into from
Dec 14, 2024
+3 −9
Merged

Bump nice-go to 1.0.0 #133185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e83ac5
Bump Nice G.O. to 1.0.0
IceBotYT Dec 14, 2024
c12cd97
Mypy
IceBotYT Dec 14, 2024
cbd27c1
Pytest
IceBotYT Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion homeassistant/components/nice_go/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ async def on_data(self, data: dict[str, Any]) -> None:
].type, # Device type is not sent in device state update, and it can't change, so we just reuse the existing one
BarrierState(
deviceId=raw_data["deviceId"],
desired=json.loads(raw_data["desired"]),
reported=json.loads(raw_data["reported"]),
connectionState=ConnectionState(
connected=raw_data["connectionState"]["connected"],
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/nice_go/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
"integration_type": "hub",
"iot_class": "cloud_push",
"loggers": ["nice_go"],
"requirements": ["nice-go==0.3.10"]
"requirements": ["nice-go==1.0.0"]
}
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1468,7 +1468,7 @@ nextdns==4.0.0
nibe==2.14.0

# homeassistant.components.nice_go
nice-go==0.3.10
nice-go==1.0.0

# homeassistant.components.niko_home_control
niko-home-control==0.2.1
Expand Down
2 changes: 1 addition & 1 deletion requirements_test_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1231,7 +1231,7 @@ nextdns==4.0.0
nibe==2.14.0

# homeassistant.components.nice_go
nice-go==0.3.10
nice-go==1.0.0

# homeassistant.components.niko_home_control
niko-home-control==0.2.1
Expand Down
4 changes: 0 additions & 4 deletions tests/components/nice_go/fixtures/get_all_barriers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
],
"state": {
"deviceId": "1",
"desired": { "key": "value" },
"reported": {
"displayName": "Test Garage 1",
"autoDisabled": false,
Expand Down Expand Up @@ -42,7 +41,6 @@
],
"state": {
"deviceId": "2",
"desired": { "key": "value" },
"reported": {
"displayName": "Test Garage 2",
"autoDisabled": false,
Expand Down Expand Up @@ -73,7 +71,6 @@
],
"state": {
"deviceId": "3",
"desired": { "key": "value" },
"reported": {
"displayName": "Test Garage 3",
"autoDisabled": false,
Expand Down Expand Up @@ -101,7 +98,6 @@
],
"state": {
"deviceId": "4",
"desired": { "key": "value" },
"reported": {
"displayName": "Test Garage 4",
"autoDisabled": false,
Expand Down
1 change: 0 additions & 1 deletion tests/components/nice_go/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ async def test_firmware_update_required(
"displayName": "test-display-name",
"migrationStatus": "NOT_STARTED",
},
desired=None,
connectionState=None,
version=None,
timestamp=None,
Expand Down