Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow load_verify_locations with only cadata passed #133299

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Dec 15, 2024

Proposed change

When calling SSLContext.load_verify_locations with only cadata provided, then no IO is done.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@mib1185 mib1185 requested a review from a team as a code owner December 15, 2024 17:32
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Dec 15, 2024
@mib1185 mib1185 added this to the 2024.12.4 milestone Dec 15, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mib1185 👍

../Frenck

@frenck frenck merged commit e951511 into home-assistant:dev Dec 15, 2024
64 checks passed
@mib1185 mib1185 deleted the block_async_io/allow-load_verify_locations-with-only-cadata branch December 15, 2024 18:31
@bdraco
Copy link
Member

bdraco commented Dec 15, 2024

Thanks @mib1185

zweckj pushed a commit to zweckj/home-assistant-core that referenced this pull request Dec 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load_verify_locations blocking I/O check needs an exception implemented for cadata via check_allowed
3 participants