Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map RGB+CCT to RGB for WLED #133900

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

mmrazik
Copy link
Contributor

@mmrazik mmrazik commented Dec 23, 2024

Proposed change

This is fixing #125656. I ran into the same problem with the following setup.
I am running wled with WS281x LEDs. These identify themselves like RGB + CCT. This is the relevant part from wled/info:

{
  "leds": {
    "count": 63,
    "pwr": 666,
    "fps": 2,
    "maxpwr": 5000,
    "maxseg": 32,
    "bootps": 0,
    "seglc": [
      5
    ],
    "lc": 5,
    "rgbw": false,
    "wv": 0,
    "cct": 4
  }
}

HomeAssistant currently identifies this as RGBWW and sends the ATTR_RGBWW_COLOR which is not recognized by the current code and is not supported by WLED itself.

Mapping this to RGB makes the color picker in HA work. I tested this with physical wled strip that identifies itself as RGB_COLOR | COLOR_TEMPERATURE.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (wled) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of wled can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign wled Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@frenck frenck added this to the 2025.1.0 milestone Dec 23, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mmrazik 👍

../Frenck

@frenck frenck changed the title Map RGB+CCT to RGB for WLED #125656 Map RGB+CCT to RGB for WLED Dec 23, 2024
@frenck frenck merged commit 8f6e4cd into home-assistant:dev Dec 23, 2024
30 checks passed
frenck pushed a commit that referenced this pull request Dec 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WLED Colour Switch not working over HA
2 participants