Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using shared aiohttp client session for Subaru integration #133931

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

G-Two
Copy link
Contributor

@G-Two G-Two commented Dec 24, 2024

Proposed change

  • Changes aiohttp_client helper call from async_get_clientsession() to async_create_clientsession()
    • Underlying API uses cookies to store session IDs
    • Fixes bug when users have more than one config entry

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck
Copy link
Member

frenck commented Dec 24, 2024

Hmm interesting, why is this happening and problematic in terms of code?

@G-Two
Copy link
Contributor Author

G-Two commented Dec 24, 2024

The user has two separate accounts to control two separate cars. The Subaru API login only occurs once during the config entry setup. Since the integration is using a a shared aiohttp client session, the second login overrides the first login session cookies. Creating separate client sessions during config entry setup should prevent this.

Same bug in the HACS version of the integration: G-Two/homeassistant-subaru#30

@frenck frenck added this to the 2025.1.0 milestone Dec 24, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check I see 👍

Thanks for the PR and happy holidays! 🎄

../Frenck

@frenck frenck merged commit 4a2ae7f into home-assistant:dev Dec 24, 2024
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subaru integration - two cars overwrite each other's sensor values.
2 participants