Added fast forward and rewind support to the Alexa cloud/smart home component #15370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: alexa
core
small-pr
ghost
added
the
…omponent. It simply invokes the next and previous track functions.
iliketoprogram14
force-pushed
the
alexa_ff_rw
branch
from
5f12f01 to
ce080bc
Compare
|
Note: I disabled the pylint warnings because pylint can't detect decorators for that error. See this issue for more info. |
|
We should not add incorrect mappings because it is confusing and it means that we need to break that in the future. |
|
That's too bad. I guess I'll have to maintain this locally then. Thanks for following up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fast forward and rewind support to the Alexa cloud/smart home component. It simply invokes the next and previous track functions.
Description:
The Alexa PlaybackController interface supports fast forward and rewind, whereas Home Assistant's media_player component does not, only next_track and previous_track. As a result, Alexa for the HA cloud skill or smart home skills does not support fast forward and rewind.
I propose adding fast forward and rewind and mapping them to next_track and previous_track, at least until Home Assistant's media_player ever gets fastforward and rewind services. I've tested this on my local setup with success. Existing users would probably have to rediscover their devices if they would want to make use of this functionality.
I'm not sure if I should add this capability to the docs here, since it might be confusing that media_player doesn't have those functions. Happy to add it if someone thinks I should.
Related issue (if applicable): N/A
Pull request in home-assistant.github.io with documentation (if applicable): N/A
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools: N/A
If the code does not interact with devices: