Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add last clean times to xiaomi vacuum #17558

Closed

Conversation

rytilahti
Copy link
Member

@rytilahti rytilahti commented Oct 17, 2018

The keys are the same as used by neato platform.

Description:

Depends on rytilahti/python-miio#413 and a release bump.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

The keys are the same as used by neato platform.
@rytilahti rytilahti force-pushed the xiaomi_last_clean_time branch from 68d48c4 to 0d35d27 Compare November 17, 2018 01:51
@rytilahti rytilahti changed the title WIP: Add last clean times to xiaomi vacuum Add last clean times to xiaomi vacuum Nov 17, 2018
@rytilahti rytilahti changed the title Add last clean times to xiaomi vacuum WIP: Add last clean times to xiaomi vacuum Nov 17, 2018
@balloob
Copy link
Member

balloob commented Nov 27, 2018

Will close this. You can re-open it when upstream PR has been released and included in HA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants