Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Z-Wave Lock Config Entry Support #18209

Merged
merged 6 commits into from
Nov 20, 2018
Merged

Z-Wave Lock Config Entry Support #18209

merged 6 commits into from
Nov 20, 2018

Conversation

cgarwood
Copy link
Member

@cgarwood cgarwood commented Nov 4, 2018 •
edited
Loading

Description:

Migrates zwave locks to config entry setup.

Related issue (if applicable): N/A
Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

zwave:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@cgarwood cgarwood requested a review from a team as a code owner November 4, 2018 22:06
@ghost ghost assigned cgarwood Nov 4, 2018
@ghost ghost added the in progress label Nov 4, 2018
houndci-bot
houndci-bot reviewed Nov 4, 2018
View reviewed changes
tests/components/lock/test_zwave.py Outdated Show resolved Hide resolved
tests/components/lock/test_zwave.py Outdated Show resolved Hide resolved
tests/components/lock/test_zwave.py Show resolved Hide resolved
@cgarwood
Copy link
Member Author

cgarwood commented Nov 6, 2018

Waiting on #18180 then I'll rebase

houndci-bot
houndci-bot reviewed Nov 6, 2018
View reviewed changes
homeassistant/components/lock/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/lock/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/lock/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/lock/__init__.py Outdated Show resolved Hide resolved
@cgarwood cgarwood changed the title WIP: Z-Wave Lock Config Entry Support Z-Wave Lock Config Entry Support Nov 16, 2018
@cgarwood
Copy link
Member Author

Anyone have any ideas on the tests? I added some debug statements and it appears that async_setup isn't getting called in components/lock/__init__.py in the test, but it does get called when you actually run HASS. Not sure why, and I've tried different things for the past week to try to fix it and have had 0 luck.

MartinHjelmare
MartinHjelmare reviewed Nov 16, 2018
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

tests/components/lock/test_zwave.py Outdated Show resolved Hide resolved
tests/components/lock/test_zwave.py Outdated Show resolved Hide resolved
@cgarwood
Copy link
Member Author

Thanks @MartinHjelmare ! Can't believe it was something so simple, but that's usually how it goes 😃

@balloob balloob merged commit e87ecbd into home-assistant:dev Nov 20, 2018
@ghost ghost removed the Ready for review label Nov 20, 2018
@balloob balloob mentioned this pull request Nov 29, 2018
Merged
@ghost ghost removed the platform: lock.zwave label Mar 21, 2019
@cgarwood cgarwood deleted the zw-lock-entry branch July 4, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@houndci-bot houndci-bot houndci-bot left review comments

Assignees

@cgarwood cgarwood

Labels
cla-signed core integration: lock integration: zwave
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cgarwood @MartinHjelmare @houndci-bot @balloob @homeassistant