Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support v7 version for Xiaomi AirPurifier PRO #19653

Closed
wants to merge 2 commits into from
Closed

Add support v7 version for Xiaomi AirPurifier PRO #19653

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ee809a
Add support v7 version for Xiaomi AirPurifier PRO
quamilek Dec 29, 2018
df7ba4c
Review changes
quamilek Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion homeassistant/components/fan/xiaomi_miio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
DATA_KEY = 'fan.xiaomi_miio'

CONF_MODEL = 'model'
MODEL_AIRPURIFIER_PRO = 'zhimi.airpurifier.v6'
MODEL_AIRPURIFIER_PRO = 'zhimi.airpurifier.v7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not that familiar with this code, but should the old v6 constant also be kept?

Copy link
Member

@syssi syssi Jan 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This line will break the V6 support!

MODEL_AIRPURIFIER_V3 = 'zhimi.airpurifier.v3'
MODEL_AIRHUMIDIFIER_V1 = 'zhimi.humidifier.v1'
MODEL_AIRHUMIDIFIER_CA = 'zhimi.humidifier.ca1'
Expand All @@ -48,6 +48,7 @@
'zhimi.airpurifier.v3',
'zhimi.airpurifier.v5',
'zhimi.airpurifier.v6',
'zhimi.airpurifier.v7',
'zhimi.airpurifier.mc1',
'zhimi.humidifier.v1',
'zhimi.humidifier.ca1',
Expand Down