-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Pollen.com sensor into IQVIA component #22986
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #22986 +/- ##
==========================================
- Coverage 94.13% 93.56% -0.58%
==========================================
Files 448 451 +3
Lines 36720 36946 +226
==========================================
+ Hits 34567 34568 +1
- Misses 2153 2378 +225
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #22986 +/- ##
==========================================
- Coverage 94.13% 93.56% -0.58%
==========================================
Files 448 451 +3
Lines 36720 36946 +226
==========================================
+ Hits 34567 34568 +1
- Misses 2153 2378 +225
Continue to review full report at Codecov.
|
3932b97
to
057f851
Compare
Codecov Report
@@ Coverage Diff @@
## dev #22986 +/- ##
=========================================
- Coverage 94.29% 94.09% -0.2%
=========================================
Files 458 452 -6
Lines 37160 36797 -363
=========================================
- Hits 35040 34625 -415
- Misses 2120 2172 +52
Continue to review full report at Codecov.
|
Breaking Change:
The
pollen
sensor platform is now theiqvia
component; theconfiguration.yaml
schema has changed accordingly.Description:
In expanding the functionality of the
pollen
sensor, I realized that the parent company (IQVIA) hosts a variety of sites (https://pollen.com, https://flustar.com, etc.) from which valid data can come. To accommodate this, I want to generalize thepollen
sensor into theiqvia
component.The PR does two things:
pypollencom
topyiqvia
.iqvia
component.This PR is a tad bigger than I would like, but it is in place to avoid multiple breaking changes. It does not implement a config entry; that will come in a separate PR.
Related issue (if applicable): N/A
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9194
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirements
in the manifest (example).requirements_all.txt
by runningscript/gen_requirements_all.py
.