Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorg Homematic IP Cloud imports and minor fixes #23330

Merged
merged 7 commits into from
Apr 23, 2019
Merged

Reorg Homematic IP Cloud imports and minor fixes #23330

merged 7 commits into from
Apr 23, 2019

Conversation

SukramJ
Copy link
Contributor

@SukramJ SukramJ commented Apr 23, 2019

Description:

  • reorg HmiP imports after introduction of manifests
  • fix usage of dimLevel (HomematicipDimmer,HomematicipNotificationLight)
  • added types to some functions
  • align naming: channel_index -> channel for (HomematicipNotificationLight)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

@SukramJ
Copy link
Contributor Author

SukramJ commented Apr 23, 2019 •
edited
Loading

Hi @MartinHjelmare ,
as far as i understood its now okay to move imports to the top.
OK?

@SukramJ SukramJ changed the title Homematic IP reorg imports and minor fixes Homematic IP Cloud: reorg imports and minor fixes Apr 23, 2019
@MartinHjelmare MartinHjelmare changed the title Homematic IP Cloud: reorg imports and minor fixes Reorg Homematic IP Cloud imports and minor fixes Apr 23, 2019
@MartinHjelmare MartinHjelmare merged commit 16d8e92 into home-assistant:dev Apr 23, 2019
@SukramJ SukramJ mentioned this pull request Apr 24, 2019
Merged
3 tasks
@SukramJ SukramJ deleted the HmIP-ReorgImports branch April 24, 2019 16:02
This was referenced Apr 28, 2019
Closed
Closed
@balloob balloob mentioned this pull request May 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed integration: homematicip_cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SukramJ @MartinHjelmare @homeassistant