-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to select photoblack cartridge #23433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a paragraph in the PR description about the breaking change for the release notes.
'cyan': ['Inklevel Cyan', '%', 'mdi:water'], | ||
'yellow': ['Inklevel Yellow', '%', 'mdi:water'], | ||
'clean': ['Inklevel Cleaning', '%', 'mdi:water'], | ||
'black': ['Ink level Black', '%', 'mdi:water'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change, since the first item will be used for entity name which will be used for entity_id.
* Added option to select photoblack cartridge * Update sensor.py * Name change
Description:
Added the option to add photo black cartridge as a setting. Also correct the spelling of Inklevel -> Ink level
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9371
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirements
in the manifest (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: