Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to select photoblack cartridge #23433

Merged
merged 3 commits into from
May 3, 2019
Merged

Added option to select photoblack cartridge #23433

merged 3 commits into from
May 3, 2019

Conversation

ThaStealth
Copy link
Contributor

@ThaStealth ThaStealth commented Apr 26, 2019

Description:

Added the option to add photo black cartridge as a setting. Also correct the spelling of Inklevel -> Ink level

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9371

Example entry for configuration.yaml (if applicable):

   - platform: epsonworkforce
     host: IP_ADDRESS
     monitored_conditions:
     - black     
     - photoblack
     - yellow
     - magenta
     - cyan
     - clean      

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@fabaff fabaff merged commit 0702407 into home-assistant:dev May 3, 2019
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a paragraph in the PR description about the breaking change for the release notes.

'cyan': ['Inklevel Cyan', '%', 'mdi:water'],
'yellow': ['Inklevel Yellow', '%', 'mdi:water'],
'clean': ['Inklevel Cleaning', '%', 'mdi:water'],
'black': ['Ink level Black', '%', 'mdi:water'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, since the first item will be used for entity name which will be used for entity_id.

@balloob balloob mentioned this pull request May 14, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
* Added option to select photoblack cartridge

* Update sensor.py

* Name change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants