Update Sesame component to use Candy House's library using the V3 API #23621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: sesame
small-pr
fabaff
reviewed
May 4, 2019
balloob
approved these changes
May 8, 2019
| if self._is_unlocked: | ||
| return STATE_UNLOCKED | ||
| return STATE_LOCKED | ||
| return STATE_LOCKED if self._is_locked else STATE_UNLOCKED |
There was a problem hiding this comment.
We shouldn't overwrite the state property. It's the responsibility of the base lock entity class.
|
|
||
| @property | ||
| def device_state_attributes(self) -> dict: | ||
| """Return the state attributes.""" | ||
| attributes = {} | ||
| attributes[ATTR_DEVICE_ID] = self._device_id | ||
| attributes[ATTR_SERIAL_NO] = self._serial |
There was a problem hiding this comment.
We don't allow serial numbers and similar static info in state attributes. The state attributes should hold info that is mostly dynamic and related to the state of the entity.
Merged
2 tasks
2 tasks
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Oct 12, 2019
…home-assistant#23621) * Update Sesame component to use Candy House's library using the V3 API * Updated requirements_all.txt * Fix pylint warning * Revert back to ATTR_DEVICE_ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
The Sesame smart lock's 1.0 API uses a username/password pair to authenticate, and may be deprecated in the future. The V3 API uses an API key, so it will require users to update their HA config.
Description:
Related issue (if applicable): fixes #19003
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9355
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirementsin the manifest (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: