-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cleaning state code for roborock s6 #25500
Add cleaning state code for roborock s6 #25500
Conversation
Hey there @rytilahti, @syssi, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
This can be merged after the CI checks are done.. As a side-note, have you seen the other two new states seen in the backend lib? The codes 100 and 101 (charging complete and device offline) added with rytilahti/python-miio#525 . |
ah thanks! added them also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the inline commentary on the new extra states.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to add the two new states as xiaomi specific state attributes for now.
I suggest we keep this PR for the STATE_CLEANING and forget about the other two ;) |
Sounds good to me, let's get this merged. Those two extra states sound odd anyway (esp. device offline). Maybe they are some internals used by the xiaomi cloud, maybe @syssi knows more. |
Breaking Change:
Description:
added state code 18 which is used by the new roborock s6 in cleaning state
Related issue (if applicable): fixes #25476
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: