Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleaning state code for roborock s6 #25500

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Add cleaning state code for roborock s6 #25500

merged 1 commit into from
Jul 30, 2019

Conversation

benleb
Copy link
Contributor

@benleb benleb commented Jul 26, 2019

Breaking Change:

Description:

added state code 18 which is used by the new roborock s6 in cleaning state

Related issue (if applicable): fixes #25476

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost
Copy link

ghost commented Jul 26, 2019

Hey there @rytilahti, @syssi, mind taking a look at this pull request as its been labeled with a integration (xiaomi_miio) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@MartinHjelmare MartinHjelmare changed the title add cleaning state code for roborock s6 Add cleaning state code for roborock s6 Jul 26, 2019
@rytilahti
Copy link
Member

This can be merged after the CI checks are done..

As a side-note, have you seen the other two new states seen in the backend lib? The codes 100 and 101 (charging complete and device offline) added with rytilahti/python-miio#525 .

@benleb
Copy link
Contributor Author

benleb commented Jul 26, 2019

ah thanks! added them also

Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline commentary on the new extra states.

homeassistant/components/xiaomi_miio/vacuum.py Outdated Show resolved Hide resolved
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add the two new states as xiaomi specific state attributes for now.

homeassistant/components/vacuum/__init__.py Outdated Show resolved Hide resolved
@benleb
Copy link
Contributor Author

benleb commented Jul 30, 2019

I suggest we keep this PR for the STATE_CLEANING and forget about the other two ;)

@rytilahti
Copy link
Member

Sounds good to me, let's get this merged. Those two extra states sound odd anyway (esp. device offline). Maybe they are some internals used by the xiaomi cloud, maybe @syssi knows more.

@rytilahti rytilahti merged commit 2c144bc into home-assistant:dev Jul 30, 2019
@benleb benleb deleted the add-roborock-s6-cleaning-code branch July 30, 2019 22:36
@lock lock bot locked and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xiaomi_miio state_code missing (18)
5 participants