Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KNX integration to xknx 0.11.3 #35154

Merged
merged 1 commit into from
May 13, 2020
Merged

Conversation

farmio
Copy link
Contributor

@farmio farmio commented May 3, 2020

Proposed change

Updates xknx requirement of knx integration to 0.11.3

  • added a lot of DPT definitions now useable as sensor type
  • add expose attribute function (eg. expose brightness of a light) and expose default value
  • default climate havc_mode to "heat" if modes are not supported (KNX Climate and Alexa #30204 (comment))
  • support update_entity service call
  • bugfixes from xknx 0.11.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

- add expose attribute function and default value
- default climate havc_mode to "heat" if modes are not supported
- support `update_entity` service call
@probot-home-assistant
Copy link

Hey there @Julius2342, mind taking a look at this pull request as its been labeled with a integration (knx) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my perspective.

@stefanlaheij
Copy link

Hi, just out of curiosity. What needs to happen before this gets merged to the next release?

@ctalkington
Copy link
Contributor

looks like this was reviewed so if you can just confirm that it works locally as i dont have any device to confirm

@farmio
Copy link
Contributor Author

farmio commented May 12, 2020

Well, it works locally for me but a second tester would be nice 😃

@cgarwood cgarwood merged commit 7147c53 into home-assistant:dev May 13, 2020
@farmio farmio deleted the xknx-0-11-3 branch May 13, 2020 13:33
@da-anda
Copy link
Contributor

da-anda commented May 20, 2020

I think this change broke my wind speed sensor which had the DTP type speed_ms before. The new name seems to be wind_speed_ms. I think it's worth mentioning in the release notes that KNX users should check their config to match the new DTP types or some entities might be broken (like the wind sensor in my case)

@farmio
Copy link
Contributor Author

farmio commented May 20, 2020

Oh, sorry. I haven't seen this one. "speed_ms" seems to be the only DPT type that was changed. The others are just additions.

@mauricederden
Copy link

I think this change broke my wind speed sensor which had the DTP type speed_ms before. The new name seems to be wind_speed_ms. I think it's worth mentioning in the release notes that KNX users should check their config to match the new DTP types or some entities might be broken (like the wind sensor in my case)


Indeed, i took me a day to find out why the speed wasn't available after an update 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KNX hub craches: APCI not supported
9 participants