-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update KNX integration to xknx 0.11.3 #35154
Conversation
- add expose attribute function and default value - default climate havc_mode to "heat" if modes are not supported - support `update_entity` service call
Hey there @Julius2342, mind taking a look at this pull request as its been labeled with a integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my perspective.
Hi, just out of curiosity. What needs to happen before this gets merged to the next release? |
looks like this was reviewed so if you can just confirm that it works locally as i dont have any device to confirm |
Well, it works locally for me but a second tester would be nice 😃 |
I think this change broke my wind speed sensor which had the DTP type |
Oh, sorry. I haven't seen this one. "speed_ms" seems to be the only DPT type that was changed. The others are just additions. |
Indeed, i took me a day to find out why the speed wasn't available after an update 👍 |
Proposed change
Updates xknx requirement of knx integration to 0.11.3
update_entity
service callType of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: