Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-miio to 0.5.2.1 #37422

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Conversation

rytilahti
Copy link
Member

@rytilahti rytilahti commented Jul 3, 2020

Breaking change

Proposed change

Bump the python-miio library to fix several issues and allow proceeding with #36539.

Changelogs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @syssi, mind taking a look at this pull request as its been labeled with an integration (xiaomi_miio) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@rytilahti rytilahti added this to the 0.112.2 milestone Jul 3, 2020
@rytilahti rytilahti marked this pull request as draft July 3, 2020 17:41
@rytilahti rytilahti marked this pull request as ready for review July 3, 2020 18:37
@MartinHjelmare MartinHjelmare changed the title Bump python-miio Bump python-miio to 0.5.2.1 Jul 3, 2020
@rytilahti
Copy link
Member Author

The test error seems to be unrelated to this change, or am I reading the log incorrectly?

ERROR:homeassistant.core:Error doing job: Task exception was never retrieved
Traceback (most recent call last):
File "/__w/1/s/homeassistant/core.py", line 1219, in async_call
raise ServiceNotFound(domain, service) from None
homeassistant.exceptions.ServiceNotFound: Unable to find service persistent_notification/create

@balloob balloob merged commit 7da3065 into home-assistant:dev Jul 3, 2020
balloob pushed a commit that referenced this pull request Jul 3, 2020
@balloob balloob mentioned this pull request Jul 3, 2020
@rytilahti rytilahti deleted the miio/bump_052 branch July 3, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment