Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to lutron_caseta to prevent it blocking startup #45769

Merged
merged 4 commits into from
Jan 31, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 31, 2021

Proposed change

Add timeout to lutron_caseta to prevent it blocking startup

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @swails, mind taking a look at this pull request as its been labeled with an integration (lutron_caseta) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco marked this pull request as draft January 31, 2021 09:18
@bdraco bdraco added this to the 2021.2.0 milestone Jan 31, 2021
@bdraco
Copy link
Member Author

bdraco commented Jan 31, 2021

I need to write tests for this, but it too late. Will do tomorrow

Copy link
Contributor

@swails swails left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bdraco bdraco marked this pull request as ready for review January 31, 2021 17:55
@balloob balloob merged commit 73d7d80 into home-assistant:dev Jan 31, 2021
c0fec0de pushed a commit to c0fec0de/home-assistant that referenced this pull request Feb 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants