Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle zeroconf discovery of zigate RadioType in zha config_flow.py #58467

Closed
wants to merge 3 commits into from
Closed

Conversation

Hedda
Copy link
Contributor

@Hedda Hedda commented Oct 26, 2021

Breaking change

No.

Proposed change

The goal is to add support for handling Zeroconf discovery of zigate RadioType in config flow for the ZHA integration.

This is in order to prepare support for network-attached ZiGate Zigbee radio gateways like the new ZiGate-Ethernet:

https://zigate.fr/produit/zigate-ethernet/

fairecasoimeme/ZiGate-Ethernet#8

fairecasoimeme/ZiGate-Ethernet#7

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Handle zeroconf discovery of zigate RadioType in zha config_flow.py
@probot-home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@Adminiuga
Copy link
Contributor

Was this tested and confirmed to work?

Update for zigate zeroconf discovery by zha
update config_flow.py
@Hedda
Copy link
Contributor Author

Hedda commented Feb 9, 2022

Closing this downstream PR until further notice since upstream PRs has not yet been reviewed or merged by @fairecasoimeme

fairecasoimeme/ZiGate-Ethernet#8

fairecasoimeme/ZiGate-Ethernet#7

@Hedda Hedda closed this Feb 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants