Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump openwrt-luci-rpc from 1.1.8 to 1.1.11 #60124

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Bump openwrt-luci-rpc from 1.1.8 to 1.1.11 #60124

merged 2 commits into from
Nov 24, 2021

Conversation

FaserF
Copy link
Contributor

@FaserF FaserF commented Nov 22, 2021

Proposed change

Bumps openwrt-luci-rpc to the latest version 1.1.11

Changelog from the openwrt-luc-rpc dev: https://github.com/fbradyirl/openwrt-luci-rpc/blob/master/HISTORY.rst
1.1.9 (2021-03-21)
Publish to pypi only once in github actions (fbradyirl/openwrt-luci-rpc#47)
1.1.10 (2021-03-21)
Also trigger the Github Actions on push of tags (fbradyirl/openwrt-luci-rpc#49)
1.1.11 (2021-03-21)
Add rst-linter pre-commit hook to prevent committing errors to HISTORY.rst fbradyirl/openwrt-luci-rpc#50

fbradyirl/openwrt-luci-rpc@v1.1.8...v1.1.11

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hi @FaserF,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @mzdrale, mind taking a look at this pull request as it has been labeled with an integration (luci) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FaserF The CI is failing, could you please take a look?

@FaserF
Copy link
Contributor Author

FaserF commented Nov 24, 2021

Done, similar issue as with here: #60125

Should be working now.

1.1.9 (2021-03-21)
Publish to pypi only once in github actions (fbradyirl/openwrt-luci-rpc#47)
1.1.10 (2021-03-21)
Also trigger the Github Actions on push of tags (fbradyirl/openwrt-luci-rpc#49)
1.1.11 (2021-03-21)
Add rst-linter pre-commit hook to prevent committing errors to HISTORY.rst fbradyirl/openwrt-luci-rpc#50
Removed dependency on openwrt-luci-rpc in tests (as no tests yet present).
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @FaserF 👍

@frenck frenck merged commit 2439f6b into home-assistant:dev Nov 24, 2021
@FaserF FaserF deleted the bump-openwrt-luci-rpc branch November 24, 2021 20:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants