Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pico remote support to non-pro lutron caseta bridges #61032

Merged
merged 9 commits into from
Dec 19, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 5, 2021

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @swails, mind taking a look at this pull request as it has been labeled with an integration (lutron_caseta) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco added waiting-for-upstream We're waiting for a change upstream and removed docs-missing labels Dec 5, 2021
@bdraco bdraco added waiting-for-upstream We're waiting for a change upstream and removed waiting-for-upstream We're waiting for a change upstream labels Dec 5, 2021
@bdraco bdraco force-pushed the lutron_caseta_pico_support branch from ad73e8f to 400129c Compare December 5, 2021 17:20
@bdraco bdraco removed the waiting-for-upstream We're waiting for a change upstream label Dec 5, 2021
@bdraco bdraco marked this pull request as ready for review December 5, 2021 17:26
@bdraco bdraco force-pushed the lutron_caseta_pico_support branch from 400129c to 6404e88 Compare December 6, 2021 03:48
@bdraco
Copy link
Member Author

bdraco commented Dec 6, 2021

No changes, rebase for conflict only

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Dec 6, 2021
@bdraco bdraco mentioned this pull request Dec 11, 2021
22 tasks
@jmarianer
Copy link

I have tested this with my own hardware (I only have the 5-button remotes) and it seems to be doing the right thing, at least for the buttons I tested.

Incidentally, did you intend to remove the "ignore" directive from mypy.ini since you added typing hints? I attempted to run it and got no errors in Lutron Caseta, which means either the hints are all correct or I messed up running mypy.

@bdraco
Copy link
Member Author

bdraco commented Dec 11, 2021

Incidentally, did you intend to remove the "ignore" directive from mypy.ini since you added typing hints? I attempted to run it and got no errors in Lutron Caseta, which means either the hints are all correct or I messed up running mypy.

Maybe at some point, but not for this PR

@bdraco
Copy link
Member Author

bdraco commented Dec 11, 2021

I have tested this with my own hardware (I only have the 5-button remotes) and it seems to be doing the right thing, at least for the buttons I tested.

Thanks! Glad to know its working for someone else. I have all the remote models except the 3 button one (I'm not sure they actually even exist).

@bdraco
Copy link
Member Author

bdraco commented Dec 19, 2021

rebase only, no changes

@bdraco bdraco force-pushed the lutron_caseta_pico_support branch from 5945243 to 8073f3b Compare December 19, 2021 07:04
@bdraco
Copy link
Member Author

bdraco commented Dec 19, 2021

Thanks 👍

@bdraco bdraco merged commit e834382 into home-assistant:dev Dec 19, 2021
@bdraco bdraco deleted the lutron_caseta_pico_support branch December 19, 2021 07:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed has-tests integration: lutron_caseta smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants