-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust SamsungTV abstraction layer #67216
Conversation
Hey there @escoand, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration ( |
cc @bdraco / @MartinHjelmare |
I think it makes sense to add this to the next beta, as it is tightly bound to #67042 |
Note: the coverage decrease was expected - I plan to reach 100% coverage in a follow-up PR |
Does it fix any user facing problems? |
Not exactly, but #67127 will (as soon as the library is released), and it will need this. |
Maybe you prefer to keep this one on hold, and include it in the next milestone at the same time as #67127? |
I don't think we should switch library in a patch release even if it fixes problems. |
Draft => I will attempt to improve coverage |
96.19% of diff hit (target 96.32%) |
4b79fcd
to
df79c14
Compare
100% coverage on bridge.py 🥇 |
100% coverage on media_player.py 🥇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks @MartinHjelmare 👍 |
Proposed change
Adjust the SamsungTV to ensure that:
async_add_executor_job
is only called in the public methods (at the top level of the abstraction layer) to avoid not needed context switches inside the abstraction implementationsAs follow-up to #67042, and preliminary work for #67127
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: