-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettify json (tests) #68888
Prettify json (tests) #68888
Conversation
I've marked this as ready for review, but should we or should we not prettify the tests/* ? |
Tricky one. I think we should, mainly because... standardize all the things 🎉 But they are testing fixtures. Formatting could break specific tests (but should/probably won't). For example, testing a bad json file/fixture. |
IMO, if one is testing a bad json file/fixture then it should be a text file and not a json file. |
Dunno... maybe :) But for now its not an issue, so lets merge it. |
Proposed change
Preliminary work for #68877
Should we or should we not prettify the
tests/*
?Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: