Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettify json (tests) #68888

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Prettify json (tests) #68888

merged 2 commits into from
Mar 30, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Mar 30, 2022

Proposed change

Preliminary work for #68877

Should we or should we not prettify the tests/* ?

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Mar 30, 2022
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 30, 2022
@epenet epenet added code-quality smash Indicator this PR is close to finish for merging or closing and removed smash Indicator this PR is close to finish for merging or closing labels Mar 30, 2022
@epenet epenet marked this pull request as draft March 30, 2022 07:38
@epenet epenet marked this pull request as ready for review March 30, 2022 08:25
@epenet
Copy link
Contributor Author

epenet commented Mar 30, 2022

I've marked this as ready for review, but should we or should we not prettify the tests/* ?

@epenet epenet mentioned this pull request Mar 30, 2022
22 tasks
@frenck
Copy link
Member

frenck commented Mar 30, 2022

Tricky one. I think we should, mainly because... standardize all the things 🎉

But they are testing fixtures. Formatting could break specific tests (but should/probably won't). For example, testing a bad json file/fixture.

@epenet
Copy link
Contributor Author

epenet commented Mar 30, 2022

IMO, if one is testing a bad json file/fixture then it should be a text file and not a json file.

@frenck
Copy link
Member

frenck commented Mar 30, 2022

IMO, if one is testing a bad json file/fixture then it should be a text file and not a json file.

Dunno... maybe :) But for now its not an issue, so lets merge it.

@frenck frenck merged commit 496d90b into home-assistant:dev Mar 30, 2022
@epenet epenet deleted the pretty-json-3 branch March 30, 2022 09:15
@epenet
Copy link
Contributor Author

epenet commented Mar 30, 2022

Thanks, I've marked #68891 and #68892 as ready accordingly

@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality core small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants