Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Issue #69037 resolved a problem where specific types of image failed the generic camera still image checks during config flow or yaml import.
This PR is to add some regression tests: The images that failed are added as test cases.
Type of change
Additional information
I would like a 2nd opinion on this because I don't know whether it's ok to add binary files to test cases like this. In particular:
1.7MB of files - is that ok?
Are there any copyright or permission issues? (I noticed some other images in the repo so maybe it's ok).
This PR fixes or closes issue: fixes #
This PR is related to issue: Improve image checks for generic camera #69037
Link to documentation pull request:
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: