Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set brand icon as entity picture on update entities #69200

Merged
merged 4 commits into from
Apr 3, 2022
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Apr 3, 2022

Proposed change

Set the brand icons for update integrations by default. This can be overridden by integrations if wanted/needed. For example: in case the integration has no brand icon, has a different source, or wants to use an MDI icon instead.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (update) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (demo) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Co-authored-by: Joakim Sørensen <ludeeus@ludeeus.dev>
tests/components/demo/test_update.py Outdated Show resolved Hide resolved
tests/components/demo/test_update.py Outdated Show resolved Hide resolved
tests/components/demo/test_update.py Outdated Show resolved Hide resolved
tests/components/demo/test_update.py Outdated Show resolved Hide resolved
tests/components/demo/test_update.py Outdated Show resolved Hide resolved
tests/components/update/test_init.py Outdated Show resolved Hide resolved
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

homeassistant/components/wled/update.py Show resolved Hide resolved
@frenck frenck merged commit b644e7e into dev Apr 3, 2022
@frenck frenck deleted the frenck-2022-0833 branch April 3, 2022 18:38
frenck added a commit that referenced this pull request Apr 4, 2022
Co-authored-by: Joakim Sørensen <ludeeus@ludeeus.dev>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants