Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise repair issue for Mi Flora #75752

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Raise repair issue for Mi Flora #75752

merged 1 commit into from
Jul 26, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Jul 26, 2022

Proposed change

This PR raises an repair issue for the Mi Flora integration, to tell the user it has been replaced by the Xiaomi BLE integration.

CleanShot 2022-07-26 at 09 36 54

CleanShot 2022-07-26 at 09 37 08

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added deprecation Indicates a breaking change to happen in the future integration: miflora labels Jul 26, 2022
@probot-home-assistant
Copy link

Hey there @Danielhiversen, @basnijholt, mind taking a look at this pull request as it has been labeled with an integration (miflora) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck marked this pull request as ready for review July 26, 2022 07:36
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 26, 2022
@frenck frenck added this to the 2022.8.0b0 milestone Jul 26, 2022
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: The common sentence: " This will no longer work" can be misunderstood to refer to the fix action being described. Maybe we should extend that sentence a bit to clarify what will no longer work.

@frenck
Copy link
Member Author

frenck commented Jul 26, 2022

CleanShot 2022-07-26 at 17 28 51

@MartinHjelmare This part is generated by the frontend and is a temporary placeholder. I was told that would be gone in the final release.

@MartinHjelmare MartinHjelmare merged commit 3ee0ca8 into dev Jul 26, 2022
@MartinHjelmare MartinHjelmare deleted the frenck-2022-1531 branch July 26, 2022 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed deprecation Indicates a breaking change to happen in the future integration: miflora smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sensor: MiFlora
5 participants