Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helpful message to the config_entries.OperationNotAllowed exception #78631

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 17, 2022

Proposed change

We only expect this exception to be raised as a result of an implementation problem. When it is raised during production it is currently hard to trace down why its happening

See #75835

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

…tion

We only expect this exception to be raised as a result of an
implementation problem. When it is raised during production
it is currently hard to trace down why its happening

See home-assistant#75835
@bdraco bdraco requested a review from a team as a code owner September 17, 2022 11:01
@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Sep 17, 2022
@bdraco bdraco added this to the 2022.9.5 milestone Sep 17, 2022
@bdraco
Copy link
Member Author

bdraco commented Sep 17, 2022

Tagging for a patch so we can hopefully figure out why #75835 is happening

@thecode thecode merged commit 74f7ae4 into home-assistant:dev Sep 17, 2022
@bdraco
Copy link
Member Author

bdraco commented Sep 17, 2022

Thanks

balloob pushed a commit that referenced this pull request Sep 18, 2022
…tion (#78631)

We only expect this exception to be raised as a result of an
implementation problem. When it is raised during production
it is currently hard to trace down why its happening

See #75835
@balloob balloob mentioned this pull request Sep 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants