-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Xiaomi Miio YAML import #78995
Conversation
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
Hey there @rytilahti, @syssi, @bieniu, mind taking a look at this pull request as it has been labeled with an integration ( |
I think not all platforms are converted to use the config flow (e.g., remote #73427), that should be done before we can deprecate the YAML configuration, I think. |
@rytilahti the YAML config for ir remotes will continue to work, this is only conserning the import of YAML to config flow. Can we just remove the option to spicify these commands? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@starkillerOG ah, I see. This looks good to me then! Should the name be changed to "Remove" instead of "Deprecate", as that is what this PR does, right?
Regarding the remote, broadlink
integration supports remotes but it is indeed a bit more complicated..
@rytilahti all checks pass, can you approve/merge? |
@bdraco could you review this and get this fix into 2022.10 beta? |
@bdraco any more feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @starkillerOG, let's merge it!
Breaking change
YAML import for the Xiaomi Miio integration is now removed, config entries have already been imported since HomeAssistant 2021.3.
Proposed change
Remove the really old (HA 2021.3) YAML import for Xiaomi Miio.
Remove the xiaomi miio gateway migration of the unique ID (also since 2021.3 already present), all schould have been migrated by now.
Ensure config_entries are only reloaded when the entry has actually changed.
Add logging in case of a unexpected error during config flow.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: