-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Anova integration #86254
Add Anova integration #86254
Conversation
I noticed that the docs mentioned YAML configuration. I don't think that will be accepted here per ADR 0010 integrations that communicate with a device/service should be config flow only. |
Thanks for the heads up! I have resolved that now |
Hi Lash-L It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello. I have a couple of comments which might help improve the code a bit as well as the component itself
Not sure why that Mariadb one keeps failing- I assume it's just the ci pipeline being weird? |
I think I recently fixed that test. It might have just needed dev merged in |
Co-authored-by: J. Nick Koston <nick@koston.org>
Thanks bdraco! I appreciate all your help! |
Proposed change
Adding read only entities for Anova Sous Vides with Wifi support. Uses anova-wifi
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: