Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Anova integration #86254

Merged
merged 82 commits into from
Apr 22, 2023
Merged

Conversation

Lash-L
Copy link
Contributor

@Lash-L Lash-L commented Jan 19, 2023

Proposed change

Adding read only entities for Anova Sous Vides with Wifi support. Uses anova-wifi

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@dshokouhi
Copy link
Member

I noticed that the docs mentioned YAML configuration. I don't think that will be accepted here per ADR 0010 integrations that communicate with a device/service should be config flow only.

@Lash-L
Copy link
Contributor Author

Lash-L commented Jan 20, 2023

I noticed that the docs mentioned YAML configuration. I don't think that will be accepted here per ADR 0010 integrations that communicate with a device/service should be config flow only.

Thanks for the heads up! I have resolved that now

@Lash-L Lash-L changed the title New Anova Sous Vide integrartion New Anova Sous Vide integration Jan 21, 2023
@home-assistant
Copy link

Hi Lash-L

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Contributor

@Vaskivskyi Vaskivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. I have a couple of comments which might help improve the code a bit as well as the component itself

homeassistant/components/anova_sous_vide/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/anova_sous_vide/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/anova_sous_vide/sensor.py Outdated Show resolved Hide resolved
@Lash-L
Copy link
Contributor Author

Lash-L commented Apr 22, 2023

Not sure why that Mariadb one keeps failing- I assume it's just the ci pipeline being weird?

@bdraco
Copy link
Member

bdraco commented Apr 22, 2023

Not sure why that Mariadb one keeps failing- I assume it's just the ci pipeline being weird?

I think I recently fixed that test. It might have just needed dev merged in

Co-authored-by: J. Nick Koston <nick@koston.org>
@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Apr 22, 2023
@bdraco bdraco merged commit 498e696 into home-assistant:dev Apr 22, 2023
@Lash-L
Copy link
Contributor Author

Lash-L commented Apr 22, 2023

Thanks bdraco! I appreciate all your help!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed has-tests integration: anova_sous_vide new-integration smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants