Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Switchbot cover is_closed, is_opening, is_closing logic #86833

Conversation

BelowAverageDev
Copy link
Contributor

Fix device class for blind and add logic to set the following:

  • is_closed
  • is_opening
  • is_closing

@home-assistant
Copy link

Hi BelowAverageDev

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @bdraco, @Danielhiversen, @RenierM26, @murtas, @Eloston, @dsypniewski, mind taking a look at this pull request as it has been labeled with an integration (switchbot) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switchbot can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign switchbot Removes the current integration label and assignees on the issue, add the integration domain after the command.

@BelowAverageDev
Copy link
Contributor Author

Note this pr targets home-assistant:jesserockz-2023-027, not dev.
Because @jesserockz branched on origin instead of a fork, I have to pr here instead of downstream. Code owners please re-assign. Sorry!

@MartinHjelmare MartinHjelmare changed the title add is_closed, is_opening, is_closing logic Add Switchbot cover is_closed, is_opening, is_closing logic Jan 28, 2023
@jesserockz jesserockz merged commit 3fcaff2 into home-assistant:jesserockz-2023-027 Jan 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants