Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _is_opening, _is_closing state attribute setting logic to use PySwitchbot==0.37.1 api #86990

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Update _is_opening, _is_closing state attribute setting logic to use PySwitchbot==0.37.1 api #86990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions homeassistant/components/switchbot/cover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,25 +177,10 @@ async def async_set_cover_tilt_position(self, **kwargs: Any) -> None:
def _handle_coordinator_update(self) -> None:
"""Handle updated data from the coordinator."""
_tilt = self.parsed_data["tilt"]
_moving_up = (
self.parsed_data["motionDirection"]["up"] and self.parsed_data["inMotion"]
)
_moving_down = (
self.parsed_data["motionDirection"]["down"] and self.parsed_data["inMotion"]
)
# NOTE: when motion is down, motion up is also set to true for some reason
if _moving_up:
_opening = bool(_tilt > 50)
_closing = not _opening
elif _moving_down:
_opening = bool(_tilt < 50)
_closing = not _opening
else:
_opening = _closing = False
self._attr_current_cover_tilt_position = _tilt
self._attr_is_closed = (_tilt < self.CLOSED_DOWN_THRESHOLD) or (
_tilt > self.CLOSED_UP_THRESHOLD
)
self._attr_is_opening = _opening
self._attr_is_closing = _closing
self._attr_is_opening = self.parsed_data["motionDirection"]["opening"]
self._attr_is_closing = self.parsed_data["motionDirection"]["closing"]
self.async_write_ha_state()