-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZHA "consumer connected" binary sensor for Xiaomi EU plugs #88194
Add ZHA "consumer connected" binary sensor for Xiaomi EU plugs #88194
Conversation
Hey there @dmulcahey, @Adminiuga, @puddly, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Marked as ready, so it can be merged before today's beta. Shouldn't cause any issues even without a zha-quirks bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
* dev: (60 commits) Update frontend to 20230222.0 (home-assistant#88615) Add controller support to `zwave_js/subscribe_firmware_update_status` (home-assistant#87348) Bump Freebox to 1.1.0 (home-assistant#88609) Always include platform in `config/entity_registry/list_for_display` (home-assistant#88601) Add dsk option to zwave_js/add_node WS command (home-assistant#87823) Update zwave_js FirmwareUploadView to support controller updates (home-assistant#87239) Add new zwave_js WS command to parse DSK from QR code (home-assistant#87237) Diagnostics report for Thread networks (home-assistant#88541) Set default for `hass_config_yaml` fixture to "" (home-assistant#88608) Bump reolink-aio to 0.5.0 (home-assistant#88594) Bump intents package version; hassil==1.0.5; home-assistant-intents==2023.2.22 (home-assistant#88605) Add Reolink update entity (home-assistant#87865) Fix cover template: optimistic mode is ignored (home-assistant#87925) Fix 500 error when getting calendar events (home-assistant#88276) Add clarifying comment about unit of elevation (home-assistant#88489) Add ZHA "consumer connected" binary sensor for Xiaomi EU plugs (home-assistant#88194) Bump Insteon dependencies (home-assistant#88514) Use load_json_object in ecobee (home-assistant#88584) Use load_json_object in html5 (home-assistant#88586) Improve type hint in homeassistant trigger (home-assistant#88596) ...
REQUIRES:
Proposed change
Adds a binary sensor entity for the "consumer connected" attribute of Xiaomi EU plugs.
The sensor turns on when a consumer is plugged in (even if the plug is turned off or the consumer isn't consuming any power).
It looks like attribute reporting is already set up out-of-the-box for the
consumer_connected
attribute.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: