-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback to device zone time or no timezone to onvif when setting time fails #91882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fails If the device does not accept a timezone, or does not support the system timezone, we try the current timezone, if that does not work we try an empty timezone. This allows us to set the time on many more devices which resolves auth problems fixes #89958
home-assistant
bot
added
bugfix
cla-signed
integration: onvif
small-pr
PRs with less than 30 lines.
labels
Apr 23, 2023
Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
bdraco
changed the title
Add fallback to device time or no timezone to onvif when setting time fails
Add fallback to device zone time or no timezone to onvif when setting time fails
Apr 23, 2023
bdraco
added
the
smash
Indicator this PR is close to finish for merging or closing
label
Apr 23, 2023
frenck
approved these changes
Apr 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
cla-signed
integration: onvif
Quality Scale: No score
small-pr
PRs with less than 30 lines.
smash
Indicator this PR is close to finish for merging or closing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
If the device does not accept a timezone, or does not support the system timezone (sometimes the timezone db is too old and no more firmware updates), we try the current timezone, if that does not work we try an empty timezone (device keeps existing timezone). This allows us to set the time on many more devices which resolves auth problems
Type of change
Additional information
ter:InvalidTimeZone Invalid data
#90820 fixes After Daylight Saving Time, Device and Systems Time Don't Match #68216Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: