Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback to device zone time or no timezone to onvif when setting time fails #91882

Merged
merged 10 commits into from
Apr 24, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 23, 2023

Proposed change

If the device does not accept a timezone, or does not support the system timezone (sometimes the timezone db is too old and no more firmware updates), we try the current timezone, if that does not work we try an empty timezone (device keeps existing timezone). This allows us to set the time on many more devices which resolves auth problems

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

… fails

If the device does not accept a timezone, or does not support
the system timezone, we try the current timezone, if that does
not work we try an empty timezone. This allows us to set the time
on many more devices which resolves auth problems

fixes #89958
@home-assistant
Copy link

Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration (onvif) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of onvif can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign onvif Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco changed the title Add fallback to device time or no timezone to onvif when setting time fails Add fallback to device zone time or no timezone to onvif when setting time fails Apr 23, 2023
@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Apr 23, 2023
@frenck frenck merged commit 392a9f3 into dev Apr 24, 2023
@frenck frenck deleted the onvif_set_time branch April 24, 2023 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed integration: onvif Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
3 participants