Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump onvif-zeep-async to 2.1.4 #92700

Closed
wants to merge 3 commits into from
Closed

Bump onvif-zeep-async to 2.1.4 #92700

wants to merge 3 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 6, 2023

Proposed change

Bump onvif-zeep-async to 2.1.4
changelog: openvideolibs/python-onvif-zeep-async@v2.1.1...v2.1.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 6, 2023

Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration (onvif) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of onvif can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign onvif Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco closed this May 6, 2023
@bdraco bdraco reopened this May 6, 2023
@bdraco bdraco closed this May 6, 2023
@bdraco bdraco reopened this May 6, 2023
@bdraco bdraco changed the title Bump onvif-zeep-async to 2.1.2 Bump onvif-zeep-async to 2.1.4 May 6, 2023
@bdraco
Copy link
Member Author

bdraco commented May 7, 2023

I'm going to wait until I get put hands on the test device as I'm making too many guesses here which is too risky

@bdraco bdraco closed this May 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2023
@bdraco bdraco deleted the onvif_wsas branch May 20, 2023 05:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants