-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix onvif cameras that cannot parse relative time #92711
Conversation
The spec requires that the camera can parse relative or absolute timestamps However there are many cameras that cannot parse time correctly. Much of the event code has been offloaded to the library and support to determine if the camera has broken time and switch to absolute timestamps is now built into the library
Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This is working great and its all bug fixes but there is a lot of refactoring here so I'm still doing a lot of manual testing. |
down to 8 more cameras to test ... |
thats all the cameras. found a small race in the webhook setup that is now fixed as well so I'll need to start testing over.... |
Looks like I'm not going to have time to finish a full retest before I'm traveling so this will have to wait a week until I get back and can finish testing. |
Retest with the original 42 cameras + the 9 more that showed up while I was traveling looks good. |
Proposed change
The spec requires that the camera can parse relative or absolute timestamps However there are many cameras that cannot parse time correctly.
Much of the event code has been offloaded to the library as support to determine if the camera has broken time and switch to absolute timestamps is now built into the library
We want to try relative times first as they are less prone to issues where ha time and camera time are not in sync
Additionally the webhook url has been shortened because the long url causes some camera to crash
changelog: openvideolibs/python-onvif-zeep-async@v2.1.1...v3.1.7
This is working great and its all bug fixes but there is a lot of refactoring here to make this work so I tested each of the 51 test cameras with this change-set.
We are making progress for sure as ONVIF jumped on analytics to 8,139 (4.2%) for 2023.5.x edit: (now 8,609 (4.5%)) edit: (now 9,096 (4.7%)) so I assume a lot more people are having successes (but we usually don't hear about those)
Type of change
Additional information
GetCapabilities
with 2023.5.x and later #92308Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: