Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert orjson to 3.9.2 #99374

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Revert orjson to 3.9.2 #99374

merged 2 commits into from
Aug 31, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 31, 2023 •
edited
Loading

Proposed change

Revert orjson to 3.9.2

Reported in #beta, observed crash and the py-spy showed it was stuck on orjson.load which lead to discovering ijl/orjson#415

Have not been able to replicate the crash since downgrading orjson. Issue reports crash is still present on 3.9.5 so reverting to 3.9.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco added this to the 2023.9.0 milestone Aug 31, 2023
@bdraco bdraco requested a review from a team as a code owner August 31, 2023 06:44
@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels Aug 31, 2023
ptz0n
ptz0n suggested changes Aug 31, 2023
View reviewed changes
Copy link

@ptz0n ptz0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case that fails with orjson@3.9.4 but passes with orjson@3.9.2.

@bdraco
Copy link
Member Author

bdraco commented Aug 31, 2023

Please add a test case that fails with orjson@3.9.4 but passes with orjson@3.9.2.

Please see the linked issue report; ijl/orjson#415

@MartinHjelmare MartinHjelmare merged commit a41af4e into dev Aug 31, 2023
@MartinHjelmare MartinHjelmare deleted the orjson_crash branch August 31, 2023 07:33
@cdce8p cdce8p mentioned this pull request Aug 31, 2023
Closed
32 tasks
bramkragten pushed a commit that referenced this pull request Aug 31, 2023
@bdraco @bramkragten
Revert orjson to 3.9.2 (#99374)
a0d03d6 
* Revert "Update orjson to 3.9.4 (#98108)"

This reverts commit 3dd377c.

* Revert "Update orjson to 3.9.3 (#97930)"

This reverts commit d993aa5.
@bdraco bdraco mentioned this pull request Sep 1, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@ptz0n ptz0n ptz0n approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.9.0
Development

Successfully merging this pull request may close these issues.

Locks up and restarts HA
5 participants
@bdraco @ptz0n @MartinHjelmare @joostlek @bramkragten