Fix console errors in LL when entities are unavailable. (#1734)

home-assistant · Oct 4, 2018 · a76386b · a76386b
1 parent 0243632
commit a76386b
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 3 deletions.
diff --git a/src/panels/lovelace/entity-rows/hui-input-number-entity-row.js b/src/panels/lovelace/entity-rows/hui-input-number-entity-row.js
@@ -125,14 +125,16 @@ class HuiInputNumberEntityRow extends mixinBehaviors([IronResizableBehavior], Po
   }
 
   _hiddenState() {
-    if (!this.$ || this._stateObj.attributes.mode !== 'slider') return;
+    if (!this.$ || !this._stateObj || this._stateObj.attributes.mode !== 'slider') return;
     const width = this.$.input_number_card.offsetWidth;
     const stateEl = this.shadowRoot.querySelector('.state');
     if (!stateEl) return;
     stateEl.hidden = width <= 350;
   }
 
   _stateObjChanged(stateObj, oldStateObj) {
+    if (!stateObj) return;
+
     this.setProperties({
       _min: Number(stateObj.attributes.min),
       _max: Number(stateObj.attributes.max),

diff --git a/src/panels/lovelace/entity-rows/hui-input-text-entity-row.js b/src/panels/lovelace/entity-rows/hui-input-text-entity-row.js
@@ -57,7 +57,7 @@ class HuiInputTextEntityRow extends PolymerElement {
   }
 
   _stateObjChanged(stateObj) {
-    this._value = stateObj.state;
+    this._value = stateObj && stateObj.state;
   }
 
   _selectedValueChanged() {

diff --git a/src/panels/lovelace/entity-rows/hui-media-player-entity-row.js b/src/panels/lovelace/entity-rows/hui-media-player-entity-row.js
@@ -89,6 +89,8 @@ class HuiMediaPlayerEntityRow extends LocalizeMixin(PolymerElement) {
   }
 
   _computeControlIcon(stateObj) {
+    if (!stateObj) return null;
+
     if (stateObj.state !== 'playing') {
       return stateObj.attributes.supported_features & SUPPORTS_PLAY ? 'hass:play' : '';
     }

diff --git a/src/panels/lovelace/entity-rows/hui-text-entity-row.js b/src/panels/lovelace/entity-rows/hui-text-entity-row.js
@@ -64,7 +64,7 @@ class HuiTextEntityRow extends LocalizeMixin(PolymerElement) {
   }
 
   _computeState(stateObj) {
-    return computeStateDisplay(this.localize, stateObj);
+    return stateObj && computeStateDisplay(this.localize, stateObj);
   }
 }
 customElements.define('hui-text-entity-row', HuiTextEntityRow);
diff --git a/src/panels/lovelace/entity-rows/hui-timer-entity-row.js b/src/panels/lovelace/entity-rows/hui-timer-entity-row.js
@@ -73,6 +73,8 @@ class HuiTimerEntityRow extends PolymerElement {
   }
 
   _computeDisplay(stateObj, time) {
+    if (!stateObj) return null;
+
     if (stateObj.state === 'idle' || time === 0) return stateObj.state;
 
     let display = secondsToDuration(time);