Add more secret string fields #10149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
previously approved these changes
Oct 4, 2021
balloob
reviewed
Oct 4, 2021
| @@ -12,6 +12,8 @@ import type { | |||
| HaFormStringSchema, | |||
| } from "./ha-form"; | |||
|
|
|||
| const SECRET_FIELDS = ["password", "client_secret", "access_secret", "secret"]; | |||
There was a problem hiding this comment.
You don't need client_secret and access_secret because we check with includes, so secret matches both.
Suggested change
| const SECRET_FIELDS = ["password", "client_secret", "access_secret", "secret"]; | |
| const SECRET_FIELDS = ["password", "secret"]; |
There was a problem hiding this comment.
ha, no. That was the old logic but you changed it. We should change that back.
There was a problem hiding this comment.
I see, yeah
Should "token" also be checked?
balloob
reviewed
Oct 4, 2021
| @@ -33,7 +35,7 @@ export class HaFormString extends LitElement implements HaFormElement { | |||
| } | |||
|
|
|||
| protected render(): TemplateResult { | |||
| return this.schema.name.includes("password") | |||
| return SECRET_FIELDS.includes(this.schema.name) | |||
There was a problem hiding this comment.
Old check was "name includes password", new check is "name == password". We should do the original check again.
balloob
approved these changes
Oct 4, 2021
bramkragten
approved these changes
Oct 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add "client_secret" and "access_secret" as maskable keys
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: