Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog-backdrop-filter fix for Safari #10485

Merged
merged 1 commit into from
Nov 1, 2021
Merged

dialog-backdrop-filter fix for Safari #10485

merged 1 commit into from
Nov 1, 2021

Conversation

noxhirsch
Copy link
Contributor

Breaking change

Proposed change

The dialog-backdrop-filter doesn't work at the moment. The -webkit- prefix should fix that. I can't test myself, because I don't have any Apple device, but I'm pretty sure that this solves the problem (https://caniuse.com/css-backdrop-filter says the same thing)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 5851fe2 into home-assistant:dev Nov 1, 2021
@noxhirsch noxhirsch deleted the patch-1 branch November 1, 2021 11:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants