Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom elements to picture-elements. #1482

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

jeradM
Copy link
Member

@jeradM jeradM commented Jul 20, 2018

Allows adding custom elements to picture-elements cards using custom: prefix similar to custom cards.

elements:
  - type: custom:circle-sensor-element
    entity: sensor.outside_temperature
    style:
      top: 50%
      left: 50%

screen shot 2018-07-19 at 6 03 09 pm

@c727
Copy link
Contributor

c727 commented Jul 20, 2018

do we want to put the element-config in element-key?

@jeradM
Copy link
Member Author

jeradM commented Jul 20, 2018

I'm not sure I understand what you mean

@c727
Copy link
Contributor

c727 commented Jul 20, 2018

elements:
  - type: custom:circle-sensor-element
    element:
      entity: sensor.outside_temperature
    style:
      top: 50%
      left: 50%

... for entity filter we also have the card-config in card

@jeradM
Copy link
Member Author

jeradM commented Jul 20, 2018

I think balloob wanted to keep it the same as regular built-in elements

@jeradM
Copy link
Member Author

jeradM commented Jul 20, 2018

or are you talking about changing it for built-ins too?

@balloob
Copy link
Member

balloob commented Jul 20, 2018

For custom cards we pass the whole block to the custom card, not just the card option. We only use the card option if a card is rendering another card like with filter.

@balloob balloob merged commit 06532de into home-assistant:master Jul 20, 2018
@ghost ghost removed the in progress label Jul 20, 2018
@balloob
Copy link
Member

balloob commented Jul 20, 2018

Dont' forget the docs!

@ghost

This comment has been minimized.

@home-assistant home-assistant locked and limited conversation to collaborators Jul 20, 2018
@jeradM jeradM deleted the customelements branch July 20, 2018 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants