Fix minify fail #1674
Merged
Fix minify fail #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minification tried to inline a function, causing a const assignment.
First tried to update the minification plugin. However, we use uglify-es which is no longer maintained. It's being dropped by the new release of uglify-webpack-plugin. However uglify-js only supports ES5. uglify-es was forked as Terser, but that had the same error.
I tried Babel Minify too, but it made Webpack choke on source maps. The issue has been open for a long time so I decide to just simplify the code and voila, minifaction works again.
Also threw in a nicer red for the error card.
Fixes #1671