Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled domain text color in entity settings #17114

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

spacegaier
Copy link
Member

@spacegaier spacegaier commented Jun 30, 2023

Breaking change

Proposed change

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@spacegaier spacegaier added this to the 2023.7 milestone Jun 30, 2023
@spacegaier spacegaier marked this pull request as ready for review June 30, 2023 09:47
bramkragten
bramkragten previously approved these changes Jun 30, 2023
@bramkragten
Copy link
Member

I think we should use a different color, going from you screenshots the contrast seems pretty low?

@spacegaier
Copy link
Member Author

That was the var that matched based on the name.

I added new screenshots using the color that the textfield placeholder is using as well. Alternatively, we can use the previous color var, but change the alpha value.

@bramkragten bramkragten enabled auto-merge (squash) June 30, 2023 14:55
@bramkragten bramkragten disabled auto-merge June 30, 2023 15:13
@bramkragten bramkragten merged commit e514651 into home-assistant:dev Jun 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[beta 2023.7] Disabled domain text in entity registry settings is too dark
2 participants