-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove turn_off from brightness slider #1715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
please don't. Using the slider to switch Off is very very useful, and if not desired can be switched off easily already by using Brightness set to 1 and 2 without any issues, killing this functionality would require more user interaction and take away this much used functionality... |
@Mariusthvdb the screenshot you're showing is not Home Assistant. It's custom UI or custom Lovelace, it has nothing to do with this repo. |
well then, this is Lovelace, with the regular HA slider. The point isn't the sceenshot. It is that in this repo functionality is cut, depriving users who do find it useful of that functionality. Btw, both Hue and Tradfri hardware dimmers can slide all the way to Off, so as it stands, Hue implementation is coherent with real life. If must be, please make it the exception and add an option to |
We're not going to add an option for that to control behavior in the more info dialog. If you want to turn it off, use the toggle at the top. |
sorry to hear, too bad really. You're limiting truly useful generic functionality. While people could just as easily have been pointed to a solution for their wishes in the current setup and available tools. It's not about adding an option, its about not taking thing out..causing a breaking change with the custom-ui. |
This makes it easier to set low brightness values by making the slider work only as a dimmer. Power must then be controlled by the switch.
The minimum is set to 1 because some bulbs will turn off with zero brightness.