Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logbook: filter by entity and period #1728

Merged
merged 8 commits into from
Oct 11, 2018
Merged

Logbook: filter by entity and period #1728

merged 8 commits into from
Oct 11, 2018

Conversation

Anonym-tsk
Copy link
Contributor

Description:

Support filtering logbook by entity and period.
PR to backend: home-assistant/core#17095

Preview

@balloob
Copy link
Member

balloob commented Oct 5, 2018

After final comment addressed and Travis build passes, this can be merged when the backend PR has been merged.

@Anonym-tsk
Copy link
Contributor Author

@balloob There is one new not translated string with key 'ui.panel.logbook.period'. Please add it to translation system.

@balloob
Copy link
Member

balloob commented Oct 5, 2018

It will be added to the translation system automatically when this PR is merged.

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok to merge when backend is merged 👍

@balloob balloob merged commit 3b425c3 into home-assistant:master Oct 11, 2018
@ghost ghost removed the in progress label Oct 11, 2018
zsarnett pushed a commit to zsarnett/home-assistant-polymer that referenced this pull request Oct 13, 2018
* Filter logbook by entity_id

* Filter logbook by period

* Filter logbook styles

* CI Fix

* Review

* Review

* CI Fix
zsarnett pushed a commit to zsarnett/home-assistant-polymer that referenced this pull request Oct 13, 2018
* Filter logbook by entity_id

* Filter logbook by period

* Filter logbook styles

* CI Fix

* Review

* Review

* CI Fix
zsarnett pushed a commit to zsarnett/home-assistant-polymer that referenced this pull request Oct 14, 2018
* Filter logbook by entity_id

* Filter logbook by period

* Filter logbook styles

* CI Fix

* Review

* Review

* CI Fix
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants