add min-width to childeren of horizontal stack #1761
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Can you add screenshots of before and after? |
|
I won't change anything in most cases, but it prevents a card in a horizontal stack to become larger (because it's children define the min-width) and the rest of the horizontal stack elements to be pushed out of the column. With some custom cards, swiper and button: And with standard cards, it can also happen: |
zsarnett
pushed a commit
to zsarnett/home-assistant-polymer
that referenced
this pull request
Oct 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent layout screwup by a card that doesn't plays nice and forces the entire flex parent element too wide.
See: https://drafts.csswg.org/css-flexbox/#min-size-auto
and https://css-tricks.com/flexbox-truncated-text/