Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lovelace: Add a label entity row #1779

Merged
merged 4 commits into from
Oct 16, 2018
Merged

Lovelace: Add a label entity row #1779

merged 4 commits into from
Oct 16, 2018

Conversation

thomasloven
Copy link
Contributor

@thomasloven thomasloven commented Oct 16, 2018

This just adds a special row to the entities card in lovelace.

It's a label.
It does nothing but display an icon and a text with slightly larger size (--paper-font-subhead).

label row

Documentation:

home-assistant/home-assistant.io#6849

@balloob
Copy link
Member

balloob commented Oct 16, 2018

It doesn't look nice. It's also too easily confused with interactive elements. Please browse the material design guidelines for an example of headers in lists..

@thomasloven
Copy link
Contributor Author

thomasloven commented Oct 16, 2018

Yeah... I really should have thought of doing that from the start...
Sorry for wasting peoples time.

more whitespace

Perhaps section would be a better name?

@balloob
Copy link
Member

balloob commented Oct 16, 2018

I like section.

@balloob
Copy link
Member

balloob commented Oct 16, 2018

Next time a Lit Element? 😉

@balloob balloob merged commit 5774d91 into home-assistant:master Oct 16, 2018
@ghost ghost removed the in progress label Oct 16, 2018
fabaff pushed a commit to home-assistant/home-assistant.io that referenced this pull request Oct 16, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants