-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix history graphs not loading #1799
Conversation
Resolves #1796 |
Aaah. That explains. |
src/mixins/localize-mixin.js
Outdated
@@ -17,12 +17,19 @@ export default dedupingMixin( | |||
* string should be passed in order, as follows: | |||
* `localize(stringKey, param1Name, param1Value, param2Name, param2Value)` | |||
*/ | |||
language: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment above is for the prop below.
Also add a comment why we have added language again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the correct fix is to just to find & replace this.language
with this.hass.language
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That also solves the problem... Occurs twice in ha-state-history-data.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also makes more sense
ad8cd21
to
07ead6e
Compare
Can someone tell me where this file located? Thanks! |
I installed the repo, Update the file as requested and update configuration.yaml like this: Still don't work. Any idea what could it be? Thanks, |
You also need to go through the whole environment setup and run the development server. But if you just want it to work, there'll probably be an 0.80.3 release within an hour or two. |
After upgrading to 0.80.3 I am still unable to load state history and history graphs are not working either. Ramps up the CPU for a while then dies out. I did manage to get it to load once but not since. |
On my side, the graph does not reload automatically in 0.80.3. I need to scroll down and up in the view or switch several times betweens my groups to force my HA to reload the graphs. After this steps, graphs are displayed and updated normally... Strange behaviour... (reproductible on both Opera/ANdroid and Firefox/Windows7 |
That sounds like a caching problem... |
This is still an issue. |
No discussion in old PRs. If it's still an issue, open a new issue. |
History graphs are not displaying since update to 0.80.2.
It seems
src/data/ha-state-history-data.js
still usesthis.language
which used to be provided by the localize-mixin.This change makes history graphs show up for me in more-info dialogs.
I haven't tested history-graphs cards etc. yet.