Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set attributes in input form controls #1805

Merged
merged 4 commits into from
Oct 19, 2018
Merged

Set attributes in input form controls #1805

merged 4 commits into from
Oct 19, 2018

Conversation

timmo001
Copy link
Contributor

@timmo001 timmo001 commented Oct 18, 2018 •
edited
Loading

Description

Adds missing attributes to input form controls.

Issue this fixes

#1567

Checklist

  • Change is tested and works on my device(s)

@ghost ghost added the in progress label Oct 18, 2018
@timmo001
Copy link
Contributor Author

timmo001 commented Oct 18, 2018 •
edited
Loading

Not tested yet. I will pull this when I get home, add any I have missed and fix any errors.

I am also unsure if these attributes are passed into ha-entity-picker or not. Will test this also.

https://github.com/home-assistant/home-assistant-polymer/blob/master/src/components/entity/ha-entity-picker.js

@timmo001
Copy link
Contributor Author

timmo001 commented Oct 18, 2018 •
edited
Loading

It looks like textarea is not supported in the top level iron-autogrow-textarea from polymer themselves. I have opened a PR here to add it:

PolymerElements/iron-autogrow-textarea#127

I have added these attributes in anyway so they will work once the PR 🤞 gets accepted and polymer is updated

@timmo001 timmo001 changed the title WIP: Set attributes in input form controls Set attributes in input form controls Oct 18, 2018
@timmo001 timmo001 changed the title Set attributes in input form controls WIP: Set attributes in input form controls Oct 18, 2018
@timmo001 timmo001 changed the title WIP: Set attributes in input form controls Set attributes in input form controls Oct 18, 2018
@balloob
Copy link
Member

balloob commented Oct 19, 2018

I would not hold my breath until they merge it

@balloob balloob merged commit 028003d into home-assistant:master Oct 19, 2018
@ghost ghost removed the in progress label Oct 19, 2018
@timmo001 timmo001 deleted the patch-1 branch October 19, 2018 08:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timmo001 @balloob @zsarnett @homeassistant