Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove narrow from strategies #18201

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Remove narrow from strategies #18201

merged 2 commits into from
Oct 16, 2023

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Oct 12, 2023

Breaking change

As far as we know no custom strategy uses this, but we might not know about all use cases, in which case this could be breaking.

Proposed change

Removes the now unused narrow param from strategies.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Cast Related to Home Assistant Cast UI label Oct 12, 2023
@steverep steverep merged commit 4b885cb into dev Oct 16, 2023
12 checks passed
@steverep steverep deleted the remove-narrow-from-strategies branch October 16, 2023 04:20
@Wesley-Vos
Copy link
Contributor

Hi,

There is currently an issue with the 2023.11 beta version that the energy dashboard is only 50% screen width due to the card-mod element being injected as a sibling of the energy dashboard. In order to solve the issue, might this PR be the root cause of the problem?

Thanks in advance!

@DigiLive
Copy link

DigiLive commented Nov 7, 2023

Actually we were using this param in our custom strategy.
What's the alternative for the strategy to know the "narrow" mode?

@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Cast Related to Home Assistant Cast UI cla-signed hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants