Allow custom UI on "card" entities #1824
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Informatic, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
ghost
added
the
|
I don't know if this has any other side effects. CC @andrey-git |
|
I don't know either. In theory In practice, at least in case of media player, everything seems to work fine. (though custom UI linked above needs some adjustments, as far as I can see) |
This will always render entities with `custom_ui_state_card` attribute set in `entities` state card. Fixes custom UI on `media_player` objects.
|
Alright, guess it's fine, will be in 81. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will always render entities with
custom_ui_state_cardattribute set inentitiesstate card. Fixes custom UI onmedia_playerobjects.This PR came out of my annoyance with whole https://community.home-assistant.io/t/custom-ui-mini-media-player/40135 topic. With this patch applied it'll be no longer necessary to add dummy
input_textentity and hide originalmedia_player. (This is especially troubling with autodetected media players)