Lovelace - Weather Card: Adjust margins and move text #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Thermostat fix * Fix for unknown operation mode * No title for you * I suck at removing unnecessary things * Fixing pointless Ternary operator
* Fix hass setting on stack * Don't set hass on pic elements if undefined * Don't set hass on entity rows if undefined * prefix config prop * Pic elements set hass yoooo * Remove interface * Make stack config private * Fix import * Lint
ghost
added
the
timmo001
changed the title
zsarnett
approved these changes
Oct 27, 2018
|
I don't like it. "Rainy" seems way too much glued to the forecast now. It's actually pretty misplaced there to begin with, it feels kinda randomply placed. I wonder if we should make the header something like |
timmo001
changed the title
|
OK. I've made the change. It now looks like this:
|
|
Also reduced some other margins that were wasting space:
|
timmo001
changed the title
balloob
approved these changes
Oct 28, 2018
|
ah changing the base screws everything up... Will try to fix |
|
Nah, doesn't screw it up, just shows that not all commits from master are in dev (because cherry-picked, they get slightly different commit sha's). Merging master -> dev and now it's all good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desctiption
Adjusts margins as to seperate out sections better.
Before
After